Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated syntax from trait alias pretty printing #105370

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

WaffleLapkin
Copy link
Member

Given the following program:

#![feature(trait_alias)]
trait A = ?Sized;

fn main() {}

Old output of rustc +nightly ./t.rs -Zunpretty=normal:

#![feature(trait_alias)]
trait A for ? Sized ;

fn main() {}

New output of rustc +a ./t.rs -Zunpretty=normal:

#![feature(trait_alias)]
trait A = ?Sized;

fn main() {}

cc @durka (you've written the FIXME in #45047, see #45047 (comment))

@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2022

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 6, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Dec 6, 2022

r? @oli-obk
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 6, 2022

📌 Commit 12ce0c2 has been approved by oli-obk

It is now in the queue for this repository.

@rustbot rustbot assigned oli-obk and unassigned cjgillot Dec 6, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2022
@klensy
Copy link
Contributor

klensy commented Dec 6, 2022

Test to check changes?

@oli-obk
Copy link
Contributor

oli-obk commented Dec 6, 2022

The pretty printer is not user visible on stable and won't ever be afaik. We only test a few pretty printer things, most are entirely untested and I don't know if it is helpful to increase test coverage for this debugging aid.

@klensy
Copy link
Contributor

klensy commented Dec 6, 2022

There exist https://github.com/rust-lang/rust/tree/master/src/test/pretty, but yes, probably not so necessary.

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 6, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#104898 (Put all cached values into a central struct instead of just the stable hash)
 - rust-lang#105004 (Fix `emit_unused_delims_expr` ICE)
 - rust-lang#105174 (Suggest removing struct field from destructive binding only in shorthand scenario)
 - rust-lang#105250 (Replace usage of `ResumeTy` in async lowering with `Context`)
 - rust-lang#105286 (Add -Z maximal-hir-to-mir-coverage flag)
 - rust-lang#105320 (rustdoc: simplify CSS selectors on top-doc and non-exhaustive toggles)
 - rust-lang#105349 (Point at args in associated const fn pointers)
 - rust-lang#105362 (Cleanup macro-expanded code in `rustc_type_ir`)
 - rust-lang#105370 (Remove outdated syntax from trait alias pretty printing)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 97008a2 into rust-lang:master Dec 6, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants