Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn newer available version of the x tool #104552

Merged
merged 16 commits into from
Jan 3, 2023
Merged

warn newer available version of the x tool #104552

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c495558
warn when there's a newer version of the x tool available
DebugSteven Nov 17, 2022
b2cd337
remove leading comma from macro expansion
DebugSteven Nov 28, 2022
b9b33d9
spawn x command and compare semvers
DebugSteven Dec 5, 2022
a917308
remove commented out old code
DebugSteven Dec 5, 2022
7fe2f73
formatting
DebugSteven Dec 5, 2022
02173f6
Update error message
DebugSteven Dec 7, 2022
430ea8d
Update error message
DebugSteven Dec 7, 2022
f50ad6c
rename wrapper-version argument for x to differentiate it from the bo…
DebugSteven Dec 7, 2022
5e67ce6
handle error case where --wrapper-version argument doesn't exist
DebugSteven Jan 1, 2023
e94354e
fix formatting
DebugSteven Jan 1, 2023
d7cac97
combine error branches
DebugSteven Jan 1, 2023
e62258e
fix typo
DebugSteven Jan 1, 2023
9aebb1e
improve error message
DebugSteven Jan 1, 2023
e9ca663
get latest x version from parsing cargo command
DebugSteven Jan 2, 2023
376dd8a
use cargo_metadata to get x version
DebugSteven Jan 3, 2023
85f649f
no_deps
DebugSteven Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
formatting
  • Loading branch information
@DebugSteven
DebugSteven committed Dec 31, 2022
commit 7fe2f73ecdde41ec3bc0bd9bfdee5cd064536d53
12 changes: 6 additions & 6 deletions src/tools/tidy/src/x_version.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,11 @@ use std::io::ErrorKind;
use std::process::{Command, Stdio};

pub fn check(bad: &mut bool) {
let result = Command::new("x")
.arg("--version")
.stdout(Stdio::piped())
.spawn();
let result = Command::new("x").arg("--version").stdout(Stdio::piped()).spawn();
let child = match result {
Ok(child) => child,
Err(e) => match e.kind() {
ErrorKind::NotFound => return (),
ErrorKind::NotFound => return,
_ => return tidy_error!(bad, "{}", e),
},
};
Expand All @@ -28,7 +25,10 @@ pub fn check(bad: &mut bool) {
build: BuildMetadata::EMPTY,
};
if version < expected {
return tidy_error!(bad, "Current version of x is {version} Consider updating to the newer version of x by running `cargo install --path src/tools/x`");
return tidy_error!(
bad,
"Current version of x is {version} Consider updating to the newer version of x by running `cargo install --path src/tools/x`"
);
}
} else {
return tidy_error!(bad, "{}", output.status);
Expand Down