Clean up query descriptions #103182
Merged
Clean up query descriptions #103182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Oct 18, 2022
This comment has been minimized.
This comment has been minimized.
|
You'll also need to bless some ui tests |
Noratrieb
force-pushed
the
query-desc-cleanup
branch
from
f0f0227 to
c4cca00
Compare
Noratrieb
commented
Oct 18, 2022
This comment has been minimized.
This comment has been minimized.
Use the same tense everywhere and prefer display over debug, as these descriptions are user facing.
Noratrieb
force-pushed
the
query-desc-cleanup
branch
from
c4cca00 to
4ed8345
Compare
oli-obk
reviewed
Oct 18, 2022
| @@ -448,7 +448,7 @@ rustc_queries! { | |||
| ) { | |||
| no_hash | |||
| desc { | |||
| |tcx| "processing {}`{}`", | |||
| |tcx| "processing MIR for {}`{}`", | |||
There was a problem hiding this comment.
Now this one is actually just about promoteds. But it's a pure caching query that does no work. Maybe we could even make it a regular function. Either way, seems ok as a weird name and doesn't really help or hinder anyone reading the cycle error
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 19, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#102863 (Standardize "use parentheses to call" suggestions between typeck and trait selection) - rust-lang#103034 (Let expressions on RHS shouldn't be terminating scopes) - rust-lang#103127 (Make transpose const and inline) - rust-lang#103153 (Allow `Vec::leak` when using `no_global_oom_handling`) - rust-lang#103182 (Clean up query descriptions) - rust-lang#103216 (Consider patterns in fn params in an `Elided(Infer)` lifetime rib.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same tense everywhere and prefer display over debug, as these descriptions are user facing.