Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More slice::partition_point examples #102507

Merged
merged 1 commit into from
Oct 19, 2022
Merged

More slice::partition_point examples #102507

merged 1 commit into from
Oct 19, 2022

Conversation

scottmcm
Copy link
Member

After seeing the discussion of binary_search vs partition_point in #101999, I thought some more example code could be helpful.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 30, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 30, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 30, 2022
@m-ou-se m-ou-se added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2022
@scottmcm scottmcm force-pushed the more-binary-search-docs branch from 4e5aa26 to 5b9a02a Compare October 15, 2022 21:04
@scottmcm
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 15, 2022
@m-ou-se
Copy link
Member

m-ou-se commented Oct 18, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 18, 2022

📌 Commit 5b9a02a has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 18, 2022
@matthiaskrgr
Rollup merge of rust-lang#102507 - scottmcm:more-binary-search-docs, …
d34ab5c 
…r=m-ou-se

More slice::partition_point examples

After seeing the discussion of `binary_search` vs `partition_point` in rust-lang#101999, I thought some more example code could be helpful.
This was referenced Oct 18, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 19, 2022
@bors
Auto merge of rust-lang#103213 - matthiaskrgr:rollup-diloxg3, r=matth…
415d8fc 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#101889 (doc: rewrite doc for uint::{carrying_add,borrowing_sub})
 - rust-lang#102507 (More slice::partition_point examples)
 - rust-lang#103164 (rustdoc: remove CSS ``@media` (min-width: 701px)`)
 - rust-lang#103189 (Clean up code-color and headers-color rustdoc GUI tests)
 - rust-lang#103203 (Retrieve LLVM version from llvm-filecheck binary if it is not set yet)
 - rust-lang#103204 (Add some more autolabels)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 18431b6 into rust-lang:master Oct 19, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 19, 2022
@scottmcm scottmcm deleted the more-binary-search-docs branch October 19, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-ou-se m-ou-se m-ou-se left review comments

Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
5 participants
@scottmcm @rustbot @rust-highfive @m-ou-se @bors