Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #100385

Merged
merged 1 commit into from
Aug 10, 2022
Merged

update Miri #100385

merged 1 commit into from
Aug 10, 2022

Conversation

RalfJung
Copy link
Member

Fixes #100361
r? @ghost

@rustbot
Copy link
Collaborator

rustbot commented Aug 10, 2022

The Miri submodule was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Aug 10, 2022

📌 Commit 3ba055f has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 10, 2022
@bors
Copy link
Contributor

bors commented Aug 10, 2022

⌛ Testing commit 3ba055f with merge 29e4a9e...

@bors
Copy link
Contributor

bors commented Aug 10, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 29e4a9e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 10, 2022
@bors bors merged commit 29e4a9e into rust-lang:master Aug 10, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 10, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #100385!

Tested on commit 29e4a9e.
Direct link to PR: #100385

🎉 miri on windows: test-fail → test-pass (cc @oli-obk @RalfJung).
🎉 miri on linux: test-fail → test-pass (cc @oli-obk @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Aug 10, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#100385!
176b2f3 
Tested on commit rust-lang/rust@29e4a9e.
Direct link to PR: <rust-lang/rust#100385>

🎉 miri on windows: test-fail → test-pass (cc @oli-obk @RalfJung).
🎉 miri on linux: test-fail → test-pass (cc @oli-obk @RalfJung).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (29e4a9e): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results
  • Primary benchmarks: ✅ relevant improvements found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions ❌
(primary)		 N/A N/A 0
Regressions ❌
(secondary)		 N/A N/A 0
Improvements ✅
(primary)		 -2.5% -2.7% 2
Improvements ✅
(secondary)		 N/A N/A 0
All ❌✅ (primary) -2.5% -2.7% 2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩

  2. number of relevant changes ↩

@RalfJung RalfJung deleted the miri branch August 11, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#100356
5 participants
@RalfJung @rustbot @bors @rust-highfive @rust-timer