Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature gate new non_exhaustive_omitted_patterns lint #89374

Closed
camelid opened this issue Sep 29, 2021 · 3 comments · Fixed by #89428
Closed

Feature gate new non_exhaustive_omitted_patterns lint #89374

camelid opened this issue Sep 29, 2021 · 3 comments · Fixed by #89428
Assignees
@rustbot
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
1.57.0

Comments

@camelid
Copy link
Member

camelid commented Sep 29, 2021 •
edited by rustbot
Loading

It will need to be feature-gated before it lands on stable in 1.57.0.

cc #89042 (comment)
cc @Nadrieril

This issue has been assigned to @DevinR528 via this comment.
@camelid camelid added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 29, 2021
@camelid camelid added this to the 1.57.0 milestone Sep 29, 2021
@Nadrieril
Copy link
Member

By when should the PR be merged if we want to get it in before 1.57.0 roughly?

@camelid
Copy link
Member Author

camelid commented Sep 29, 2021

I'm not 100% sure, but I think 1.57 will be promoted to beta in ~2 weeks. After that, the PR would need a backport to the beta branch in order to get it in before 1.57 is released as stable. (You can see the release dates here. Nightly branches off as beta around 7 weeks before it is released as stable IIRC.)

@camelid
Copy link
Member Author

camelid commented Sep 30, 2021

From #89042 (comment):

I can work on adding the feature gate I'll open a PR and cc both of you (as long as that's ok?).

@rustbot assign @DevinR528

@rustbot rustbot self-assigned this Sep 30, 2021
This was referenced Oct 1, 2021
Merged
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Oct 5, 2021
@Manishearth
Rollup merge of rust-lang#89423 - DevinR528:reachable-fields, r=Nadri…
87f782e 
…eril

Fix ICE caused by non_exaustive_omitted_patterns struct lint

fixes rust-lang#89382

Add check that a list of `Pat`s is non empty to prevent ICE in `FnCtxt::lint_non_exhaustive_omitted_patterns`.

Is related to rust-lang#89374 and rust-lang#89105
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 10, 2021
@matthiaskrgr
Rollup merge of rust-lang#89428 - DevinR528:reachable-featuregate, r=…
29fc7bd 
…Nadrieril,camelid

Feature gate the non_exhaustive_omitted_patterns lint

Fixes rust-lang#89374

Add the machinery to gate the new `non_exhaustive_omitted_patterns` lint.

relates to rust-lang#89105 and rust-lang#89423
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 10, 2021
@matthiaskrgr
Rollup merge of rust-lang#89428 - DevinR528:reachable-featuregate, r=…
924eff1 
…Nadrieril,camelid

Feature gate the non_exhaustive_omitted_patterns lint

Fixes rust-lang#89374

Add the machinery to gate the new `non_exhaustive_omitted_patterns` lint.

relates to rust-lang#89105 and rust-lang#89423
@bors bors closed this as completed in cfa5391 Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustbot rustbot

Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging a pull request may close this issue.

Feature gate the non_exhaustive_omitted_patterns lint DevinR528/rust
3 participants
@Nadrieril @camelid @rustbot