Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows builds use external assembler #8809

Closed
vadimcn opened this issue Aug 28, 2013 · 2 comments · Fixed by #10874
Closed

Windows builds use external assembler #8809

vadimcn opened this issue Aug 28, 2013 · 2 comments · Fixed by #10874
Labels
O-windows Operating system: Windows

Comments

@vadimcn
Copy link
Contributor

vadimcn commented Aug 28, 2013

Windows builds currently use external assembler for the sake of generating correct stack unwinding tables (see #8596). This, of course, slows down the build and also creates a dependency on the assembler tool.

Eventually it would be nice to figure out what's wrong with LLVM's integrated assembler, and switch back to using it.
@ILyoan
Copy link
Contributor

ILyoan commented Aug 29, 2013

Now we have upgraded llvm which contains patches for arm unwind table generation.
Thus I think we can turn off the android-ndk assembly pass. I'll take look at it.

@ILyoan ILyoan mentioned this issue Aug 29, 2013
Closed
@sanxiyn
Copy link
Member

sanxiyn commented Sep 2, 2013

Android half is fixed in #8931.

@vadimcn vadimcn mentioned this issue Dec 9, 2013
Merged
@bors bors closed this as completed in e5f2021 Dec 9, 2013
xFrednet pushed a commit to xFrednet/rust that referenced this issue May 21, 2022
@bors
Auto merge of rust-lang#8809 - Alexendoo:metadata-collection-expect, …
77effb7 
…r=xFrednet

Ignore unfulfilled_lint_expectations in metadata collection

r? `@xFrednet`

When metadata collection is enabled the regular early/late pass registrations are skipped, which the `#[expect()]`s were no fan of: https://github.com/rust-lang/rust-clippy/runs/6356675328?check_suite_focus=true

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use LLVM's integrated assembler on Windows vadimcn/rust
3 participants
@sanxiyn @ILyoan @vadimcn