Dynamic library facilities are not supported on Windows #7095
Comments
bors
added a commit
that referenced
this issue
Jun 17, 2013
The code compiles and runs under windows now, but I couldn't look up any symbol from the current executable (dlopen(NULL)), and calling looked up external function handles doesn't seem to work correctly under windows. This the beginning of a fix for #7095.
|
This appears to have been added/fixed in 4c90b98, and there are test so closing. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
May 20, 2021
match_single_binding: Fix invalid suggestion when match scrutinee has side effects fixes rust-lang#7094 changelog: `match_single_binding`: Fix invalid suggestion when match scrutinee has side effects --- `Expr::can_have_side_effects` is used to determine the scrutinee has side effects, while this method is a little bit conservative for our use case. But I'd like to use it to avoid reimplementation of the method and too much heuristics. If you think this is problematic, then I'll implement a custom visitor to address it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Much of the work for implementing dynamic library support on Windows has been accomplished in #7027 but there is still a little bit left to fix up so that it can be turned on.
The text was updated successfully, but these errors were encountered: