Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Odd doc wording for std::io::Read::read_vectored #70154

Closed
adrian5 opened this issue Mar 19, 2020 · 0 comments · Fixed by #71296
Closed

Odd doc wording for std::io::Read::read_vectored #70154

adrian5 opened this issue Mar 19, 2020 · 0 comments · Fixed by #71296
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@adrian5
Copy link
Contributor

adrian5 commented Mar 19, 2020

This method must behave as a single call to read with the buffers concatenated would. [src]

I'm not sure what exactly it's trying to express, but it looks like an oversight.
@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Mar 19, 2020
@ChiefMilesEdgeworth ChiefMilesEdgeworth mentioned this issue Apr 18, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Apr 28, 2020
@Dylan-DPC
Rollup merge of rust-lang#71296 - ChiefMilesEdgeworth:fix_doc_wording…
1275688 
…, r=Dylan-DPC

Change wording on read_vectored docs

Closes rust-lang#70154

I'm happy to work with others to make the wording on this more clear. I think what I have is an improvement but may not be the final wording.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Apr 28, 2020
@Dylan-DPC
Rollup merge of rust-lang#71296 - ChiefMilesEdgeworth:fix_doc_wording…
2de3703 
…, r=Dylan-DPC

Change wording on read_vectored docs

Closes rust-lang#70154

I'm happy to work with others to make the wording on this more clear. I think what I have is an improvement but may not be the final wording.
@bors bors closed this as completed in fb1aa56 Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change wording on read_vectored docs ChiefMilesEdgeworth/rust
2 participants
@jonas-schievink @adrian5