Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust documentation doesn't show implementations when cookies / storage are disabled #61239

Closed
starblue opened this issue May 27, 2019 · 0 comments · Fixed by #61462
Closed

Rust documentation doesn't show implementations when cookies / storage are disabled #61239

starblue opened this issue May 27, 2019 · 0 comments · Fixed by #61462
Assignees
@GuillaumeGomez
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@starblue
Copy link 

TypeError: localStorage is null storage1.36.0.js:1:1164
    getCurrentValue file:///home/juergen/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share/doc/rust/html/storage1.36.0.js:1
    <anonymous> file:///home/juergen/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share/doc/rust/html/storage1.36.0.js:1
@jonas-schievink jonas-schievink added C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 27, 2019
@GuillaumeGomez GuillaumeGomez self-assigned this Jun 2, 2019
@GuillaumeGomez GuillaumeGomez mentioned this issue Jun 2, 2019
Merged
bors added a commit that referenced this issue Jul 12, 2019
@bors
Auto merge of #61462 - GuillaumeGomez:fix-local-storage, r=Manishearth
71f9384 
[rustdoc] Fix storage usage when disabled

Fixes #61239.

@starblue: Can you give a try to this change please? I tried on chrome and firefox and both worked so if you're using another web browser, that might be useful. :)

r? @Manishearth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[rustdoc] Fix storage usage when disabled GuillaumeGomez/rust
3 participants
@jonas-schievink @GuillaumeGomez @starblue