Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some warnings are not errors when compiling rustc #57178

Closed
varkor opened this issue Dec 28, 2018 · 1 comment · Fixed by #57184
Closed

Some warnings are not errors when compiling rustc #57178

varkor opened this issue Dec 28, 2018 · 1 comment · Fixed by #57184
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@varkor
Copy link
Member

varkor commented Dec 28, 2018

rustc should not compile with any warnings. Some warnings are currently denied, but not all: see #57177, for instance, where a warning got through.
@oli-obk
Copy link
Contributor

oli-obk commented Dec 28, 2018

stage 0 libcore/std never denied warnings as far as I know

@varkor varkor mentioned this issue Dec 28, 2018
Merged
@estebank estebank added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Dec 29, 2018
@oli-obk oli-obk mentioned this issue Jan 17, 2019
Closed
bors added a commit that referenced this issue Feb 9, 2019
@bors
Auto merge of #57184 - varkor:deny-warnings-lib, r=Mark-Simulacrum
312f382 
Deny warnings in libcore and libstd

This probably fixes #57178 (though there may still be some crates that need warnings denied). At least after this change, rustc currently produces no warnings during compilation.

r? @oli-obk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deny warnings in libcore and libstd varkor/rust
3 participants
@oli-obk @estebank @varkor