Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lldb tests are only run on macOS #54721

Closed
tromey opened this issue Oct 1, 2018 · 1 comment
Closed

lldb tests are only run on macOS #54721

tromey opened this issue Oct 1, 2018 · 1 comment
Assignees
@tromey
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.)

Comments

@tromey
Copy link
Contributor

tromey commented Oct 1, 2018

In #54004 I discovered that lldb tests are only run on macOS:

                return if builder.config.build.contains("apple") {
...

I think it would be better to test lldb and gdb based on availability, not build OS.
@tromey tromey added the A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) label Oct 1, 2018
@tromey tromey self-assigned this Oct 3, 2018
@tromey
Copy link
Contributor Author

tromey commented Oct 3, 2018

I have a patch but it depends on #54764, so I'm waiting for that to land first.

This was referenced Oct 8, 2018
Merged
Merged
tromey added a commit to tromey/rust that referenced this issue Oct 10, 2018
@tromey
Run both lldb and gdb tests
ac66b04 
Currently lldb tests are run only on macOS, and gdb tests are only run
elsewhere.  This patch changes this to run tests depending on what is
available.

One test is changed, as it was previously marked as failing on macOS,
whereas really it is a generic failure with lldb.

Closes rust-lang#54721
@tromey tromey mentioned this issue Oct 10, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Oct 18, 2018
@kennytm
Rollup merge of rust-lang#54964 - tromey:run-both-gdb-and-lldb-tests,…
43ac030 
… r=nikomatsakis

Run both lldb and gdb tests

Currently lldb tests are run only on macOS, and gdb tests are only run
elsewhere.  This patch changes this to run tests depending on what is
available.

One test is changed, as it was previously marked as failing on macOS,
whereas really it is a generic failure with lldb.

Closes rust-lang#54721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tromey tromey

Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tromey