Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nll] unresolved inference variable in outlives: _#3t #53568

Closed
nikomatsakis opened this issue Aug 21, 2018 · 1 comment · Fixed by #53580
Closed

[nll] unresolved inference variable in outlives: _#3t #53568

nikomatsakis opened this issue Aug 21, 2018 · 1 comment · Fixed by #53580
Assignees
@nikomatsakis
Labels
A-NLL Area: Non-lexical lifetimes (NLL) NLL-complete Working towards the "valid code works" goal T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
Rust 2018 RC

Comments

@nikomatsakis
Copy link
Contributor

The latest crater run reported some ICE errors that look very similar to #52057 (but are potentially different). This crate is small but pretty involved with its wrappers over hyper, tokio, and futures, resulting in a lot of associated types and bounds, and some of those 'static bounds might have a weird interaction with the NLL typeck, impl Trait, and maybe delay_span_bug.

@lqd minimized it to only one such error, but note that the real code has 5 or 6 of them, so it would be good to verify any potential fix on the hyper-stub crate itself rather than just this minimized repro. Playground.

List of crate failures
@nikomatsakis nikomatsakis added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-NLL Area: Non-lexical lifetimes (NLL) WG-compiler-nll NLL-complete Working towards the "valid code works" goal labels Aug 21, 2018
@nikomatsakis nikomatsakis added this to the Rust 2018 RC milestone Aug 21, 2018
@lqd lqd mentioned this issue Aug 21, 2018
Closed
2 tasks
@nikomatsakis nikomatsakis mentioned this issue Aug 21, 2018
Merged
@nikomatsakis
Copy link
Contributor Author

Fix in #53580

@nikomatsakis nikomatsakis self-assigned this Aug 22, 2018
bors added a commit that referenced this issue Aug 27, 2018
@bors
Auto merge of #53580 - nikomatsakis:nll-issue-53568, r=pnkfelix
8785e34 
fix NLL ICEs

Custom type-ops reuse some of the query machinery -- but while query results are canonicalized after they are constructed, custom type ops are not, and hence we have to resolve the type variables to avoid an ICE here.

Also, use the type-op machinery for implied outlives bounds.

Fixes #53568
Fixes #52992
Fixes #53680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikomatsakis nikomatsakis

Labels
A-NLL Area: Non-lexical lifetimes (NLL) NLL-complete Working towards the "valid code works" goal T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
Rust 2018 RC
Development

Successfully merging a pull request may close this issue.

fix NLL ICEs nikomatsakis/rust
1 participant
@nikomatsakis