-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of unicode_internals points people to issue #0 #49983
Comments
zackmdavis
added a commit
to zackmdavis/rust
that referenced
this issue
Apr 15, 2018
The unstable-feature attribute requires an issue (neglecting it is E0547), which gets used in the error messages. Unfortunately, there are some cases where "0" is apparently used a placeholder where no issue exists, directing the user to see the (nonexistent) issue #0. (It would have been better to either let `issue` be optional—compare to how issue is an `Option<u32>` in the feature-gate declarations in libsyntax/feature-gate.rs—or actually require that an issue be created.) Rather than endeavoring to change how `#[unstable]` works at this time (given competing contributor and reviewer priorities), this simple patch proposes the less-ambitious solution of just not adding the "(see issue)" note when the number is zero. Resolves rust-lang#49983.
Merged
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Apr 24, 2018
don't see issue #0 The unstable-feature attribute requires an issue (neglecting it is E0547), which gets used in the error messages. Unfortunately, there are some cases where "0" is apparently used a placeholder where no issue exists, directing the user to see the (nonexistent) issue #0. (It would have been better to either let `issue` be optional—compare to how issue is an `Option<u32>` in the feature-gate declarations in libsyntax/feature-gate.rs—or actually require that an issue be created.) Rather than endeavoring to change how `#[unstable]` works at this time (given competing contributor and reviewer priorities), this simple patch proposes the less-ambitious solution of just not adding the "(see issue)" note when the number is zero. Resolves rust-lang#49983.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is no issue #0 :-) I'm guessing someone intended #0 to mean "we don't have an issue for this", but either the error message emitting machinery needs to suppress it, or it should be given a real error message. Here's what it looks like:
You can see it here: https://travis-ci.org/alex/ct-tools/builds/366818424
The text was updated successfully, but these errors were encountered: