CStr::from_ptr documentation should mention that the C string's data must not change #48401
Labels
A-docs
Area: Documentation for any part of the project, including the compiler, standard library, and tools
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
Comments
sfackler
added
the
A-docs
|
Good suggestion! I'm adding it. |
kennytm
added
the
C-enhancement
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Mar 6, 2018
…abnik Add new warning for CStr::from_ptr Fixes rust-lang#48401. r? @steveklabnik
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Mar 6, 2018
…abnik Add new warning for CStr::from_ptr Fixes rust-lang#48401.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Callers of
std::ffi::CStr::from_ptrare responsible for ensuring that the bytes pointed to byptr, up through the terminating null byte, do not change during the lifetime of the returned&CStr. This is arguably implicit in the fact that the return value is a shared reference, but it seems to me it would be helpful to spell it out, along with the other stipulations already listed infrom_ptr's documentation.The text was updated successfully, but these errors were encountered: