Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement an ability to only run tests on a particular platform #47459

Closed
nagisa opened this issue Jan 15, 2018 · 4 comments · Fixed by #47487
Closed

Implement an ability to only run tests on a particular platform #47459

nagisa opened this issue Jan 15, 2018 · 4 comments · Fixed by #47487
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@nagisa
Copy link
Member

nagisa commented Jan 15, 2018

Currently we have an ability to specify targets to ignore tests on some platforms in form of //ignore-<arch> comment appearing somewhere in the file.

These attributes, however, are hardly usable when a test is intended to target a single architecture, as you’d have to specify every architecture test is not targeting.

The idea is to implement an attribute // only-<target>, which essentially an equivalent to specifying // ignore-* for every target but the <target>.

The relevant location to change would be here.
@nagisa nagisa added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Jan 15, 2018
@Pulkit07
Copy link
Contributor

Thanks for the file link. I am going to try fix this.

@ollie27
Copy link
Member

ollie27 commented Jan 15, 2018

dupe of #33581?

@Pulkit07
Copy link
Contributor

@ollie27 yes looks like so. I will jump to that. Thanks.

@nagisa
Copy link
Member Author

nagisa commented Jan 15, 2018

Well, this has (admittedly terse) instructions. Just make sure to note both issues as "Fixed" when submitting a PR, that’s about it.

This was referenced Jan 15, 2018
Closed
Closed
Pulkit07 added a commit to Pulkit07/rust that referenced this issue Jan 16, 2018
@Pulkit07
implement "only-<platforms>" for test headers
fd075c6 
This patch implements "only-<platforms>" for tests headers using which one can
specify just the platforms on which the test should run rather than listing all
the platforms to ignore using "ignore-<platforms>".

This is a fix for issues rust-lang#33581 and rust-lang#47459.
@Pulkit07 Pulkit07 mentioned this issue Jan 16, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Jan 17, 2018
@kennytm
Rollup merge of rust-lang#47487 - Pulkit07:foo, r=kennytm
ee636ed 
implement "only-<platforms>" for test headers

This patch implements "only-<platforms>" for tests headers using which one can
specify just the platforms on which the test should run rather than listing all
the platforms to ignore using "ignore-<platforms>".

This fixes rust-lang#33581 and fixes rust-lang#47459.
kennytm added a commit to kennytm/rust that referenced this issue Jan 17, 2018
@kennytm
Rollup merge of rust-lang#47487 - Pulkit07:foo, r=kennytm
5e1f442 
implement "only-<platforms>" for test headers

This patch implements "only-<platforms>" for tests headers using which one can
specify just the platforms on which the test should run rather than listing all
the platforms to ignore using "ignore-<platforms>".

This fixes rust-lang#33581 and fixes rust-lang#47459.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implement "only-<platforms>" for test headers Pulkit07/rust
3 participants
@nagisa @ollie27 @Pulkit07