Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macros: syntax errors in matches should fail on definition, not use #39404

Closed
jseyfried opened this issue Jan 30, 2017 · 0 comments · Fixed by #39419
Closed

macros: syntax errors in matches should fail on definition, not use #39404

jseyfried opened this issue Jan 30, 2017 · 0 comments · Fixed by #39419
Assignees
@jseyfried
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..)

Comments

@jseyfried
Copy link
Contributor

For example,

macro_rules! m { ($i) => {} }
// m!(); // uncommenting this causes an error at the def site
@jseyfried jseyfried self-assigned this Jan 30, 2017
@jseyfried jseyfried added the A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) label Jan 30, 2017
@jseyfried jseyfried mentioned this issue Jan 31, 2017
Merged
@jseyfried jseyfried mentioned this issue Feb 18, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 1, 2017
@frewsxcv
Rollup merge of rust-lang#39419 - jseyfried:simplify_tokentree, r=nrc
4ba49ab 
Simplify `TokenTree` and fix `macro_rules!` bugs

This PR
 - fixes rust-lang#39390, fixes rust-lang#39403, and fixes rust-lang#39404 (each is a [breaking-change], see issues for examples),
 - fixes rust-lang#39889,
 - simplifies and optimizes macro invocation parsing,
 - cleans up `ext::tt::transcribe`,
 - removes `tokenstream::TokenTree::Sequence` and `Token::MatchNt`,
   - instead, adds a new type `ext::tt::quoted::TokenTree` for use by `macro_rules!` (`ext::tt`)
 - removes `parser.quote_depth` and `parser.parsing_token_tree`, and
 - removes `quote_matcher!`.
   - Instead, use `quote_tokens!` and `ext::tt::quoted::parse` the result with `expect_matchers=true`.
   - I found no outside uses of `quote_matcher!` when searching Rust code on Github.

r? @nrc
bors added a commit that referenced this issue Mar 1, 2017
@bors
Auto merge of #39419 - jseyfried:simplify_tokentree, r=nrc
7ce1fbe 
Simplify `TokenTree` and fix `macro_rules!` bugs

This PR
 - fixes #39390, fixes #39403, and fixes #39404 (each is a [breaking-change], see issues for examples),
 - fixes #39889,
 - simplifies and optimizes macro invocation parsing,
 - cleans up `ext::tt::transcribe`,
 - removes `tokenstream::TokenTree::Sequence` and `Token::MatchNt`,
   - instead, adds a new type `ext::tt::quoted::TokenTree` for use by `macro_rules!` (`ext::tt`)
 - removes `parser.quote_depth` and `parser.parsing_token_tree`, and
 - removes `quote_matcher!`.
   - Instead, use `quote_tokens!` and `ext::tt::quoted::parse` the result with `expect_matchers=true`.
   - I found no outside uses of `quote_matcher!` when searching Rust code on Github.

r? @nrc
@jseyfried jseyfried mentioned this issue May 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jseyfried jseyfried

Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify TokenTree and fix macro_rules! bugs jseyfried/rust
1 participant
@jseyfried