De-duplicate methods in core::path(2) when default trait methods work #3227
Comments
ghost
assigned 
|
Blocked on #2794. |
|
Still legit, 2013-06-12. (Note: #2794 may well be fixed shortly, worth revisiting soon!) |
|
Default methods work now. |
bors
added a commit
that referenced
this issue
Sep 6, 2013
…chton (cc: #3227) Parts I'm unsure about and would like a reviewer to look at are: * `pub trait GenericPath : Clone + Eq + ToStr` -- is this the done thing? I've never done trait inheritance before, let alone from multiple traits, but it seemed to be necessary to be able to call all the methods we have to be able to call on `self`. * changing the argument of `components` from `self` to `&self`, and having it return `self.components.clone()` instead of `self.components`; this was necessary to avoid move errors, but I'm not sure if it's the right thing. (The default methods impls now all have to call `self.components()` instead of just referencing the field `self.components`.)
bors
added a commit
that referenced
this issue
Sep 6, 2013
…chton (cc: #3227) Parts I'm unsure about and would like a reviewer to look at are: * `pub trait GenericPath : Clone + Eq + ToStr` -- is this the done thing? I've never done trait inheritance before, let alone from multiple traits, but it seemed to be necessary to be able to call all the methods we have to be able to call on `self`. * changing the argument of `components` from `self` to `&self`, and having it return `self.components.clone()` instead of `self.components`; this was necessary to avoid move errors, but I'm not sure if it's the right thing. (The default methods impls now all have to call `self.components()` instead of just referencing the field `self.components`.)
|
#8909 closes this. |
jaisnan
added a commit
to jaisnan/rust-dev
that referenced
this issue
Jul 29, 2024
While at it, I also added a `--skip-libs` to skip rebuilding the Kani libraries and standard library at every `cargo build-dev` execution. We usually only need to rebuild the libraries when we make changes to them or when we update the Rust toolchain. Rebuilding them can be quite time consuming when you are making changes to Kani. Towards rust-lang#3226 rust-lang#3153 Co-authored-by: Jaisurya Nanduri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The new path code has a bunch of duplicate code between the posix and windows variants. It should be factored into material in the abstract Path trait, when default methods work.
The text was updated successfully, but these errors were encountered: