Add more lint checks for style

[brson]

We have one now that checks for camel case on types, variants and traits.

We have some other rules:

• consts are all caps Uppercase statics lint #7523
• every other ident is lower case and underscores

Let's have lint passes for those as well.

[nikomatsakis]

I put this on as a 1.0 milestone because I think that having such lint checks enabled (to warn, probably) by default is something we really ought to have before we release. Specifically I am thinking of warning if variant names are lowercase or variable names are upper case---capitalization rules on types I think are less important.

[graydon]

oops, closed by accident (wrong bug)

[pnkfelix]

Visiting for bug triage, 2013 june 26.

I guess this bug is really a meta-bug, collecting lint additions that the rust dev team wants in as rules for the rustc and standard library code base before 1.0 is released.

There is still at least issue #4639 to resolve, so I'm leaving this open. (Once #4639 is resolved, then I'm guessing we'll close and reopen it as necessary to track whether lint items remain to do.)

[emberian]

Visiting for triage; nothing to add.

[brson]

Still want more of these. Any ideas?

[pnkfelix]

accepted for P-low

[pnkfelix]

tagging as a good mentorship bug, with @brson as the mentor.

[huonw]

Some more ideas:

• Generic type parameters should be camel case, lifetimes should be snake case. (Although people rarely go beyond a single letter for either.)
• modules should be snake case
• no outer parens on if and match conditions

[pnkfelix]

@huonw Does all-caps count as an instance of camel-case? If I need more than one letter in a type-param, I will often go for a (short) all-caps word.

[huonw]

Oh, it probably passes the camel case checker, but I normally do Foo for longer parameters (hence my suggestion of camel case); maybe I'm going against the prevailing style.

I guess we need to decide on a style for type parameters before linting them.

[pnkfelix]

@huonw I suspect the prevailing style is to use less than 26 type parameters. ;)

[brson]

I believe camel case is more common for typarams than allcaps.

[Rdbaker]

I'd love to start contributing! Is this a good place to start?

[ftxqxd]

#15773 extended the existing lints to detect more cases where the Rust style for naming is not being used. That means that it detects non-uppercase statics, non-camel-case types and type parameters, and non-snake-case variables, struct/struct variant fields, lifetimes, functions, methods, and modules. (I might’ve missed something, but I think that’s it.) Is there anything else left with regards to naming? And what other lints are missing for this issue to be closed? Also, should non_uppercase_statics be set to warn by default? All the other naming lints are.

This is what I’ve come up with in the way of remaining style lints:

• Pattern bindings with names the same as variants or statics. This probably couldn’t be done with a (normal) lint, because most of the time this would throw an error, and lints occur only if compilation was successful.
• Line length. I seriously doubt it’s possible for a normal lint to do this, but it’s still part of Rust’s style (albeit an often-disputed one).

[steveklabnik]

I'm pulling a massive triage effort to get us ready for 1.0. As part of this, I'm moving stuff that's wishlist-like to the RFCs repo, as that's where major new things should get discussed/prioritized.

This issue has been moved to the RFCs repo: rust-lang/rfcs#609