Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for RFC amendment #1384 #30450

Closed
2 tasks done
pnkfelix opened this issue Dec 17, 2015 · 2 comments
Closed
2 tasks done

Tracking issue for RFC amendment #1384 #30450

pnkfelix opened this issue Dec 17, 2015 · 2 comments
Assignees
@pnkfelix
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Dec 17, 2015 •
edited
Loading

Need to implement RFC amendment rust-lang/rfcs#1384 to RFC 550 (macro input future proofing)

  • land amendment with warning for macro definitions that were previously accepted but will error in next cycle
  • after a cycle, promote the warning to an error.
@pnkfelix pnkfelix self-assigned this Dec 17, 2015
@pnkfelix
Copy link
Member Author

cc #20563

@pnkfelix pnkfelix mentioned this issue Dec 17, 2015
Closed
@steveklabnik steveklabnik added the B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. label Dec 18, 2015
@durka durka mentioned this issue Jan 3, 2016
Closed
This was referenced Jan 4, 2016
Merged
Closed
@pnkfelix pnkfelix mentioned this issue Jan 7, 2016
Closed
pnkfelix added a commit to pnkfelix/rust that referenced this issue Jan 7, 2016
@pnkfelix
macro_rules: proper FIRST/FOLLOW computations for checking macro_rule…
076e644 
…s validity.

See RFC amendment 1384 and tracking issue 30450:
  rust-lang/rfcs#1384
  rust-lang#30450

Moved old check_matcher code into check_matcher_old

combined the two checks to enable a warning cycle (where we will
continue to error if the two checks agree to reject, accept if the new
check says accept, and warn if the old check accepts but the new check
rejects).
@pnkfelix pnkfelix mentioned this issue Jan 8, 2016
Merged
nagisa added a commit to nagisa/rust that referenced this issue Jan 11, 2016
@nagisa
Rollup merge of rust-lang#30694 - pnkfelix:issue-25658-real-first-fol…
6d6e831 
…low, r=nrc

Proper first and follow sets for macro_rules future proofing

implements first stage of RFC amendment 1384; see rust-lang#30450
@pnkfelix pnkfelix mentioned this issue Jan 14, 2016
Closed
@pnkfelix pnkfelix mentioned this issue Jun 2, 2016
Merged
@brson brson added the B-unstable Blocker: Implemented in the nightly compiler and unstable. label Mar 1, 2017
@Mark-Simulacrum Mark-Simulacrum added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC and removed C-enhancement Category: An issue proposing an enhancement or a PR with one. C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Jul 22, 2017
@pnkfelix
Copy link
Member Author

The warning was upgraded to an error in #33982.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnkfelix pnkfelix

Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @brson @pnkfelix @Mark-Simulacrum