Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove (some?) shape tags post-snapshot #2694

Closed
graydon opened this issue Jun 21, 2012 · 2 comments
Closed

Remove (some?) shape tags post-snapshot #2694

graydon opened this issue Jun 21, 2012 · 2 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@graydon
Copy link
Contributor

graydon commented Jun 21, 2012

As per fixme in rust_shape.h
@graydon
Copy link
Contributor Author

graydon commented Jun 21, 2012

Removed

@graydon graydon closed this as completed Jun 21, 2012
@graydon
Copy link
Contributor Author

graydon commented Jun 21, 2012

Removed by dc11396

RalfJung pushed a commit to RalfJung/rust that referenced this issue Nov 27, 2022
@bors
Auto merge of rust-lang#2694 - RalfJung:retag-deref-check, r=saethlin
66354f0 
fix handling of spurious accesses during retag

The `dereferenceable` attribute we emit for LLVM is checked during retag in Stacked Borrows.
However, we currently don't properly do that for retagging of `&mut !Unpin`, which this PR fixes.
Also this adjusts retagging to inform the data race model of the accesses as well.

Fixes rust-lang/miri#2648.
Also fixes rust-lang/miri#2693 since the same issue arose for retagging as well.

r? `@saethlin`
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2694 - RalfJung:retag-deref-check, r=saethlin
9f30f00 
fix handling of spurious accesses during retag

The `dereferenceable` attribute we emit for LLVM is checked during retag in Stacked Borrows.
However, we currently don't properly do that for retagging of `&mut !Unpin`, which this PR fixes.
Also this adjusts retagging to inform the data race model of the accesses as well.

Fixes rust-lang/miri#2648.
Also fixes rust-lang/miri#2693 since the same issue arose for retagging as well.

r? `@saethlin`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@graydon