-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge keywords: impl and implements #2301
Comments
I'm fine with changing "implements" to something else, but using |
Classes and impls should use the same keyword to say what iface they are implementing. impls currently use |
How about |
I think niko suggested : on irc? |
Oh yeah, now I remember that. Sure, ':' is ok. I haven't seen any objections to it, so will implement that. |
I like |
@brson and @nikomatsakis both indicated on IRC support for this, with the revised syntax:
|
I like it. Will do. |
Two downsides, which do not really matter:
|
@Lenny222 I don't care about the first one that much; I do think the second one matters, but we should probably have better IDE-ish tools anyway that would obviate the need for grepping :-) |
Strengthen C++20 SC accesses `@SabrinaJewson` noted in rust-lang#2301 that Miri could produce behaviours forbidden under C++20 even without SC fences. Due to the added coherence-ordered before relationship which is created from read from and read before, plus the fact that coherence-ordered before between SC operations must be consistent with the Global Total Order S, in C++20 if there's an SC load that reads from any store, then a later SC load cannot read before that store. This PR adds this restriction
Co-authored-by: Zyad Hassan <[email protected]>
I would prefer to see
class C impl D
rather thanclass C implements D
. The latter feels redundant and verbose, and I think the former is unambiguous.The text was updated successfully, but these errors were encountered: