Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for RFC 490 - DST syntax changes #19607

Closed
nrc opened this issue Dec 6, 2014 · 10 comments
Closed

Tracking issue for RFC 490 - DST syntax changes #19607

nrc opened this issue Dec 6, 2014 · 10 comments
Assignees
@nrc
Labels
A-DSTs Area: Dynamically-sized types (DSTs) B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Milestone
1.0

Comments

@nrc
Copy link
Member

nrc commented Dec 6, 2014

Change Sized? T to T: ?Sized and trait T for Sized? to trait T for ?Sized.

Nominated because backwards incompatible - lang
@nrc nrc added I-nominated B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. A-DSTs Area: Dynamically-sized types (DSTs) labels Dec 6, 2014
@nrc nrc mentioned this issue Dec 6, 2014
Merged
@nrc
Copy link
Member Author

nrc commented Dec 6, 2014

RFC: https://github.com/rust-lang/rfcs/blob/master/text/0490-dst-syntax.md

@nrc
Copy link
Member Author

nrc commented Dec 6, 2014

Happy to mentor this if anyone wants to do it. It requires some changes to the parser and then a bunch of cleanup of libraries etc. Probably the easiest way to handle the fallout will be to accept both the old and new forms and remove the old form after a snapshot.

@nrc nrc added the E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. label Dec 6, 2014
@nrc nrc self-assigned this Dec 6, 2014
@nrc
Copy link
Member Author

nrc commented Dec 6, 2014

I've assigned myself so I don't forget this, but I'm happy if anyone wants to take this.

@tomjakubowski
Copy link
Contributor

The syntax in the OP (T ?Sized) seems to disagree with the syntax in the RFC (T: ?Sized), which one is it?

Also, a gentle reminder that rustdoc should be updated to render the new syntax too!

@nrc
Copy link
Member Author

nrc commented Dec 11, 2014

The RFC is right (and I've updated the OP).

@brson brson added this to the 1.0 milestone Dec 11, 2014
@brson
Copy link
Contributor

brson commented Dec 11, 2014

1.0 P-backcompat-lang

@jroesch
Copy link
Member

jroesch commented Dec 19, 2014

Is anyone actively working this? I'm looking to pick something else up to work on concurrently to the where clause stuff. I was also recently working on the parser for where clauses and think I won't need much guidance.

@nrc
Copy link
Member Author

nrc commented Dec 24, 2014

@jroesch sorry didn't see your comment until now, but yes, I'm working on it

@nrc nrc mentioned this issue Dec 24, 2014
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue Dec 30, 2014
@alexcrichton
rollup merge of rust-lang#20194: nick29581/dst-syntax
2a85477 
Part of rust-lang#19607.

r? @nikomatsakis
@aturon
Copy link
Member

aturon commented Jan 8, 2015

I believe this is complete, nominating for closure.

@nrc nrc removed the I-nominated label Jan 8, 2015
@nrc
Copy link
Member Author

nrc commented Jan 8, 2015

Yeah, should have been closed by #20602

@nrc nrc closed this as completed Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nrc nrc

Labels
A-DSTs Area: Dynamically-sized types (DSTs) B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
5 participants
@brson @tomjakubowski @jroesch @aturon @nrc