Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustdoc font glitch #16372

Closed
retep998 opened this issue Aug 8, 2014 · 6 comments
Closed

Rustdoc font glitch #16372

retep998 opened this issue Aug 8, 2014 · 6 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@retep998
Copy link
Member

retep998 commented Aug 8, 2014

On a Windows computer with anti-aliasing disabled using Firefox the following rendering issue occurs.

Changing the font from Source Code Pro to anything else fixes it.
@huonw huonw added the A-rustdoc label Aug 9, 2014
@Boddlnagg
Copy link
Contributor

A similar thing happens for me on http://play.rust-lang.org/ with the '&&' token (a single '&' doesn't trigger it). I haven't checked the font there but I guess it's somehow related. It's in Firefox on Windows, with anti-aliasing:
rust-play-font

@adrientetar
Copy link
Contributor

capture

Is fine. (However I get the double ampersand botch with antialiasing disabled)

Can you explain why someone would want to disable anti-aliasing? Right now it's a bit like saying "rustdoc search does not work on computers with JS disabled".
Also can you detail which version of Windows you are using.

@adrientetar
Copy link
Contributor

@Boddlnagg play.rust-lang.org might be using a too old version of Source Code Pro since it fetches from Google Font.
adobe-fonts/source-code-pro#11

Something weird through is that it's claimed to have been fixed in version 1.010 and Google Font serves version 1.017… in any case rustdoc serves the latest version which does not seem affected by this is bug so I think you should report it on rust-lang/rust-playpen (cc @thestinger).

This was referenced Aug 14, 2014
Closed
Closed
@Boddlnagg
Copy link
Contributor

I hadn't realized that local fonts are preferred over webfonts. I had an old version of Source Code Pro installed that still had the bug. Maybe it's the same for you, @retep998?

@retep998
Copy link
Member Author

Some people use aliased text because for whatever reason they find anti-aliased text to be unreadable and gives them a headache.
Anyways, confirmed that it was an old local copy of Source Code Pro that was causing the issue.

@adrientetar
Copy link
Contributor

Anyways, confirmed that it was an old local copy of Source Code Pro that was causing the issue.

So that explains it – can you close this issue? Or should we document this.

@nstoddard nstoddard mentioned this issue Apr 12, 2015
Closed
@retep998 retep998 mentioned this issue Aug 10, 2015
Closed
@ghost ghost mentioned this issue May 26, 2016
Closed
@shepmaster shepmaster mentioned this issue Mar 6, 2017
Open
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 21, 2024
@bors
Auto merge of rust-lang#16372 - davidsemakula:import-granularity-one,…
3f4c6da 
… r=Veykril

feat: Add "One" import granularity

Adds a new import granularity option "One" that merges all imports into a single use statement as long as they have the same visibility and attributes.

This is similar to [rustfmt's `imports_granularity = "One"`](https://rust-lang.github.io/rustfmt/?version=v1.6.0&search=import#imports_granularity).

Fixes: rust-lang#11361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@retep998 @Boddlnagg @huonw @adrientetar @thestinger