Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time::Tm::rfc3339 docs incorrectly refer to RFC 3999 #16158

Closed
anguslees opened this issue Aug 1, 2014 · 1 comment
Closed

time::Tm::rfc3339 docs incorrectly refer to RFC 3999 #16158

anguslees opened this issue Aug 1, 2014 · 1 comment

Comments

@anguslees
Copy link
Contributor

Easy typo fix that makes it harder than it should be to seach/grep for the right function. The docs for rfc3339 refer to a non-existent RFC 3999:
* Returns a time string formatted according to RFC 3999. RFC 3999 is
* compatible with ISO 8601.

The function is named correctly. The comment should be s/RFC 3999/RFC 3339/g
@anguslees anguslees mentioned this issue Aug 1, 2014
Closed
@omasanori
Copy link
Contributor

Oh, it's my fault. Sorry.

bors added a commit that referenced this issue Aug 2, 2014
@bors
auto merge of #16164 : anguslees/rust/rfc3999, r=alexcrichton
020b91b 
Fixes #16158
@bors bors closed this as completed in 4d52e43 Aug 2, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 3, 2024
@bors
Auto merge of rust-lang#16158 - saiintbrisson:fix/mbe/desugar-comment…
484525f 
…-to-raw-string, r=Veykril

fix(mbe): desugar doc correctly for mbe

Fixes rust-lang#16110.

The way rust desugars doc comments when expanding macros is rendering it as raw strings delimited with hashes. Rust-analyzer wasn't aware of this, so the desugared doc comments wouldn't match correctly when on the LHS of macro declarations.

This PR fixes this by porting the code used by rustc:
https://github.com/rust-lang/rust/blob/59096cdad0e527ce4d254b55aca58539f726d3d6/compiler/rustc_ast/src/tokenstream.rs#L662-L671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct RFC reference in time::Tm::rfc3339 docs anguslees/rust
2 participants
@omasanori @anguslees