Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for adding partial_cmp to PartialOrd #14987

Closed
alexcrichton opened this issue Jun 17, 2014 · 4 comments
Closed

Tracking issue for adding partial_cmp to PartialOrd #14987

alexcrichton opened this issue Jun 17, 2014 · 4 comments
Assignees
@sfackler
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Milestone
1.0

Comments

@alexcrichton
Copy link
Member

Tracking issue for rust-lang/rfcs#100.

Nominating.
@sfackler sfackler self-assigned this Jun 18, 2014
@sfackler
Copy link
Member

First bug found! https://github.com/rust-lang/rust/blob/master/src/libcollections/vec.rs#L383

@sfackler
Copy link
Member

TreeMap as well: https://github.com/rust-lang/rust/blob/master/src/libcollections/treemap.rs#L73

@brson brson added this to the 1.0 milestone Jun 19, 2014
@brson
Copy link
Contributor

brson commented Jun 19, 2014

1.0, P-backcompat-libs.

@sfackler
Copy link
Member

sfackler commented Jul 1, 2014

#15030

@sfackler sfackler closed this as completed Jul 1, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 17, 2023
@bors
Auto merge of rust-lang#15152 - alibektas:14987, r=Veykril,lowr
aa91eda 
assist : generate trait from impl

fixes rust-lang#14987 . As the name suggests this assist is used to generate traits from inherent impls while adapting the original impl to fit to the newly generated trait. I made some decisions regarding when the assist should be applicable. These are surely open to discussion. I looking forward to any feedback.

![generate_trait_from_impl_v1](https://github.com/rust-lang/rust-analyzer/assets/20956650/05d4dda5-604a-4108-8b82-9b60bd45894a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfackler sfackler

Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@alexcrichton @brson @sfackler