Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json test_read_{list,object}_streaming are flaky on 32-bit #14064

Closed
alexcrichton opened this issue May 9, 2014 · 6 comments
Closed

json test_read_{list,object}_streaming are flaky on 32-bit #14064

alexcrichton opened this issue May 9, 2014 · 6 comments
Labels
O-x86_32 Target: x86 processors, 32 bit (like i686-*)

Comments

@alexcrichton
Copy link
Member

These tests have been seen to be flaky on 32-bit with a very obscure error:

---- json::tests::test_read_object_streaming stdout ----
    task 'json::tests::test_read_object_streaming' failed at 'assertion failed: `(left == right) && (right == left)` (left: `BooleanValue(true)`, right: `BooleanValue(true)`)', C:\bot\slave\auto-win-32-opt\build\src\libserialize\json.rs:3062

---- json::tests::test_read_list_streaming stdout ----
    task 'json::tests::test_read_list_streaming' failed at 'assertion failed: `(left == right) && (right == left)` (left: `BooleanValue(true)`, right: `BooleanValue(true)`)', C:\bot\slave\auto-win-32-opt\build\src\libserialize\json.rs:3062

I find these error messages curious. These tests only fail on windows, and they only fail with optimization turned on. I suspect an LLVM bug here, but I haven't confirmed it. For now I'm going to ignore these tests on windows.
alexcrichton added a commit to alexcrichton/rust that referenced this issue May 9, 2014
@alexcrichton
serialize: Ignore two flaky json tests on windows
300109e 
See rust-lang#14064 for some rationale, but the basic idea is that I suspect that there
is an LLVM codegen bug somewhere, and I'm not entirely sure why it's happening
intermittently rather than deterministically...

cc rust-lang#14064
@alexcrichton alexcrichton mentioned this issue May 9, 2014
Merged
bors added a commit that referenced this issue May 10, 2014
@bors
auto merge of #14065 : alexcrichton/rust/ignore-flaky-windows-test, r…
5b4774d 
…=brson

See #14064 for some rationale, but the basic idea is that I suspect that there
is an LLVM codegen bug somewhere, and I'm not entirely sure why it's happening
intermittently rather than deterministically...

cc #14064
@klutzy
Copy link
Contributor

klutzy commented May 13, 2014

From #14083 (auto-linux-32-nopt-t failure log), it may be flaky on other 32-bit machines.

@alexcrichton alexcrichton changed the title json test_read_{list,object}_streaming are flaky on windows json test_read_{list,object}_streaming are flaky on 32-bit May 13, 2014
@alexcrichton
Copy link
Member Author

Ah yes, sorry, I meant to update this bug. I have noticed and reproduced this on 32-bit platforms in general.

alexcrichton added a commit to alexcrichton/rust that referenced this issue May 13, 2014
@alexcrichton
serialize: Broaden ignores of json tests
af00c57 
It was thought that these failures only happened on windows, turns out they
happen on any 32-bit machine.

cc rust-lang#14064
@alexcrichton alexcrichton mentioned this issue May 13, 2014
Closed
bors added a commit that referenced this issue May 14, 2014
@bors
auto merge of #14178 : alexcrichton/rust/more-ignores, r=brson
2e02f6e 
It was thought that these failures only happened on windows, turns out they
happen on any 32-bit machine.

cc #14064
@frewsxcv
Copy link
Member

frewsxcv commented Feb 3, 2015

visiting for triage

Can confirm these tests are still ignored:

I unfortunately don't have a 32 bit window machine to test them on though :(

@steveklabnik
Copy link
Member

Triage: same as @frewsxcv , These are still presently ignored, but I don't have the proper machinery.

@alexcrichton , should we maybe try removing the ignore, and letting bors take a look? If it was a bug in LLVM, well, a lot has changed since 2014....

@alexcrichton
Copy link
Member Author

Sure, I'd be game for unignoring them

nagisa added a commit to nagisa/rust that referenced this issue Aug 29, 2016
@nagisa
Unignore the json tests on 32-bit platforms
f53415f 
cc rust-lang#14064
@nagisa nagisa mentioned this issue Aug 29, 2016
Merged
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 31, 2016
Rollup merge of rust-lang#36123 - nagisa:unignore-json-tests, r=alexc…
e69d65c 
…richton

Unignore the json tests on 32-bit platforms

cc rust-lang#14064

r? @alexcrichton
@Mark-Simulacrum
Copy link
Member

#36123 unignored these, so this can [probably] be closed.

@TimNN TimNN closed this as completed Oct 29, 2016
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 13, 2023
@bors
Auto merge of rust-lang#14064 - WaffleLapkin:simplify_is_exit_check, …
d805c74 
…r=lnicola

minor: Simplify `is_exit` check in `lsp-server`

(this is what `socket` one does)
@Noratrieb Noratrieb added O-x86_32 Target: x86 processors, 32 bit (like i686-*) and removed O-x86-all labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-x86_32 Target: x86 processors, 32 bit (like i686-*)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@steveklabnik @alexcrichton @frewsxcv @TimNN @klutzy @Mark-Simulacrum @Noratrieb