Docs now have poor information density

[emberian]

I'm really sorry that I didn't bring this up in the earlier reviews I did of the work, but I was on my desktop with a 1080p screen, and also just didn't notice.

Here are two screenshots:

I note a few specific regressions:

• Monospaced text that is inline with other text is now way larger than the other text.
• References to types/traits/etc in the headers for an impl section are not monospaced
• Amount of whitespace around impl and impl methods makes much fewer methods fit on screen at once. This isn't very nice, since now I need to scroll a lot more to view the same amount of information.

The first two just seem like bugs (references to items should always be monospaced, perhaps?), but the latter is a more nuanced design decision. It seems to me that there is too much whitespace in general, and that the spacing between almost everything ought to be reduced.

Another point, almost more aesthetic than functional, is that the distance between a header and the line underneath it is slightly too large, and makes it more difficult to view them as a "single unit".

[emberian]

cc @thehydroimpulse @adrientetar

[lifthrasiir]

The lines below headings in the different levels are also indistinguishable now. I'd prefer not to have lines below the non-top-level headings; they can be distinguished with the appropriate amount of spacing.

[bachm]

The docs were more readable with the previous font. The orange and green text was also more readable on the light grey background than on white.

[adrientetar]

Monospaced text that is inline with other text is now way larger than the other text.

From my investigations, this is not an issue with the actual body copy font.

Consolas:

Inconsolata:

Seems like Inconsolata has a quite low xheight, I will see about replacing it (have Anonymous Pro or Source Code Pro in mind).

(Note: I had to zoom at 200% to see it and even there it's a tiny difference, so it does not seem too bad to me anyway.)

References to types/traits/etc in the headers for an impl section are not monospaced

Right, fixed on my side.

Amount of whitespace around impl and impl methods makes much fewer methods fit on screen at once. This isn't very nice, since now I need to scroll a lot more to view the same amount of information.

Agreed. I didn't look at such pages while developing the layout, I will fix this.

---

The docs were more readable with the previous font.

Because it is a serif font? – If so it is a matter of accomodation, few websites make use of them actually (for instance, blog or newspaper).

[adrientetar]

Source Code Pro is looking good? I will add it to #13587.

(400% zoom)

[bachm]

Because it is a serif font?

Mainly due to poor information density, but I simply find Consolas to be more readable than Inconsolata because it's "fatter".

[emberian]

I think I would prefer a sans-serif typeface. The screenshot you gave with source code pro looks good.

[huonw]

Along these lines: headers within a doc comment now take up a lot of space, and look a lot like they're page layout headings, not just subheadings for a specific function (e.g. the failure heading in http://static.rust-lang.org/doc/master/std/c_str/struct.CString.html#method.with_ref).

[adrientetar]

Along these lines: headers within a doc comment now take up a lot of space, and look a lot like they're page layout headings, not just subheadings for a specific function (e.g. the failure heading in http://static.rust-lang.org/doc/master/std/c_str/struct.CString.html#method.with_ref).

Thanks for the pointer, looks like I only fixed a part of this.