Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mac-32 nopt builds are broken again #12985

Closed
alexcrichton opened this issue Mar 18, 2014 · 0 comments
Closed

mac-32 nopt builds are broken again #12985

alexcrichton opened this issue Mar 18, 2014 · 0 comments

Comments

@alexcrichton
Copy link
Member

The builders were failing with: LLVM ERROR: Section too large, can't encode r_address (0x10000f3) into 24 bits of scattered relocation entry which generally means that we're generating absurdly large binaries.

Bisection points at e02aa72, which is likely because the entire pretty printer is now generic instead of codegen'd.

cc @eddyb
@alexcrichton alexcrichton mentioned this issue Mar 18, 2014
Closed
alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 18, 2014
@alexcrichton
syntax: Don't parameterize the the pretty printer
5481c6f 
The pretty printer constitues an enormous amount of code, there's no reason for
it to be generic. This just least to a huge amount of metadata which isn't
necessary. Instead, this change migrates the pretty printer to using a trait
object instead.

Closes rust-lang#12985
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 13, 2023
@bors
Auto merge of rust-lang#13961 - lowr:fix/impl-missing-members-type-ne…
27c9c2f 
…q, r=Veykril

fix: don't generate `PartialEq`/`PartialOrd` methods body for types don't match

Fixes rust-lang#12985

This PR changes the implementation of well-known trait methods body generation so that it takes generic arguments of traits into account and does not generate `PartialEq`/`PartialOrd` methods body when the self type and rhs type don't match.

I took this opportunity to add `hir::TraitRef`, which has been suggested by a FIXME note. I didn't change the signature of the existing method `hir::Impl::trait_(self, db) -> Option<Trait>` as suggested by FIXME but added a new method because you quite often only want to know the trait rather than `TraitRef`s.
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 27, 2024
@bors
Auto merge of rust-lang#12985 - llogiq:fix-integration-test, r=Alexendoo
9628130 
use short message format in integration test

While checking rust-lang#12983, bors came upon a cargo change that put "E0463" into the standard error (as part of a test case code snippet), which the integration test picked up to fail the build. Talk about unforeseen consequences.

So this PR just changes the integration test to use short message format in order to not include the code snippets in the output. Hopefully that will fix the problem.

r? `@Alexendoo`

---

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

syntax: Don't parameterize the the pretty printer alexcrichton/rust
1 participant
@alexcrichton