-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICE: assertion failed: !ty.has_non_region_infer()
#122638
Comments
Same cause as #123141 |
I'm interested in working on this. I'm preparing a PR for this fix. |
I misspoke, I'm not actually working on this one right now. I commented under the wrong issue, but since I'm trying to help fix specialization ICE I can take a look once I'm done with the other one. |
It looks like the code above doesn't reproduce ice since late May, so I'm leaving another code with same ICE message but without struct Bar;
trait Trait: Sized {
type Assoc;
}
impl Trait for Bar { }
impl Trait for <Bar as Trait>::Assoc {
fn bar() -> impl Sized {
loop {}
}
}
fn main() {} Meta
Output
|
huh, did our bug-has-test test diverge from the original reproducer here? and thus we didn't notice it getting fixed? |
The test got removed in d5bd4e2 🤔 |
yea, we really need some automation adding |
I think I left this open because the underlying problem isn't fixed even if that exact case worked. I wrote a more detailed comment on the other issue. I'm not really sure what the right thing to do is in cases like this where the bug in a crashes/*** test gets masked and starts passing but we need to make sure to keep tracking the fact that the compiler is broken. It feels a bit wrong to mark a PR as fixing a bug when all it does is mask it |
With #123141 fixed the underlying cause here should be resolved so this just needs a test (re) added to close this |
Rollup of 10 pull requests Successful merges: - rust-lang#134498 (Fix cycle error only occurring with -Zdump-mir) - rust-lang#134977 (Detect `mut arg: &Ty` meant to be `arg: &mut Ty` and provide structured suggestion) - rust-lang#135390 (Re-added regression test for rust-lang#122638) - rust-lang#135393 (uefi: helpers: Introduce OwnedDevicePath) - rust-lang#135440 (rm unnecessary `OpaqueTypeDecl` wrapper) - rust-lang#135441 (Make sure to mark `IMPL_TRAIT_REDUNDANT_CAPTURES` as `Allow` in edition 2024) - rust-lang#135444 (Update books) - rust-lang#135450 (Fix emscripten-wasm-eh with unwind=abort) - rust-lang#135452 (bootstrap: fix outdated feature name in comment) - rust-lang#135454 (llvm: Allow sized-word rather than ymmword in tests) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#135390 - ranger-ross:readd-test-122638, r=BoxyUwU Re-added regression test for rust-lang#122638 Re-adds the test for rust-lang#122638 😄 fixes rust-lang#122638 r? `@BoxyUwU` (please let me know if this can be improved. I am still fairly new to using compiletest)
snippet, original probably from
tests/ui/const-generics/type-dependent/issue-70507.rs
Version information
Command:
/home/matthias/.rustup/toolchains/master/bin/rustc
Program output
The text was updated successfully, but these errors were encountered: