Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./x test bootstrap shows curl progress bars #120133

Closed
Teapot4195 opened this issue Jan 19, 2024 · 7 comments
Closed

./x test bootstrap shows curl progress bars #120133

Teapot4195 opened this issue Jan 19, 2024 · 7 comments
Assignees
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Teapot4195
Copy link
Contributor

Teapot4195 commented Jan 19, 2024

Steps to reproduce

  1. clear the files under build/cache/[date] for those that aren't for your host triple.
  2. clear the folders under build that isn't for your host triple. (e.g. aarch64-apple-darwin if building on x86-64-windows-msvc)
  3. run ./x test bootstrap
  4. observe under a block of 37 tests, the curl progress bar shows up 6 times.

Ideal solution

  • When building the command for curl, possibly suppress the progress bar with -s in tests.
  • Possibly don't download for those targets in the first place?
    • The tools being downloaded appear to be native (not cross), I can't really see a use given they can't run on a mismatched host triple.

If someone happens to know where these curl commands are being called from, that would be helpful :)

For whoever picks up this issue: I can't exactly mentor this issue but if you do need help, feel free to ping me on zulip.

Labeled easy since it doesn't look that difficult to fix.

@rustbot label +C-enhancement +E-easy

@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Jan 19, 2024
@AnmolSirola
Copy link

@Teapot4195 Can I take this issue.

@Teapot4195
Copy link
Contributor Author

@Teapot4195 Can I take this issue.

Sure

@Teapot4195
Copy link
Contributor Author

Remember to claim via rustbot so other people know it's been taken :)

@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2024

Error: Parsing assign command in comment failed: ...' assign
' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@AnmolSirola
Copy link

@rustbot assign @AnmolSirola

@saethlin saethlin added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jan 27, 2024
@onur-ozkan
Copy link
Member

This will be fixed once #121091 is merged.

@Teapot4195
Copy link
Contributor Author

Teapot4195 commented Feb 14, 2024

This will be fixed once #121091 is merged.

Yeah, I'll close as completed (when merged) then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

5 participants