Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We are not running std tests for wasm #112009

Open
jyn514 opened this issue May 26, 2023 · 1 comment
Open

We are not running std tests for wasm #112009

jyn514 opened this issue May 26, 2023 · 1 comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented May 26, 2023

I tried this code:

x test library --exclude alloc --stage 0

I expected to see this happen: "Testing stage0 library artifacts {std, panic_abort, core, panic_unwind, unwind, proc_macro, test} (x86_64-unknown-linux-gnu)"

Instead, this happened: "Testing stage0 library artifacts"

This gets worse - if I just pass x test --exclude alloc, then the entire step gets skipped. In particular, this means that

# Exclude library/alloc due to OOM in benches.
ENV SCRIPT python3 ../x.py test --stage 2 --host='' --target $TARGETS \
--exclude library/alloc
is excluding all standard library tests, not just the ones for alloc.

Meta

HEAD is branched from 19ee7f4a6abaf00f3d11d1c7f1d3508b55c84aa1 (which is going to land on master shortly).

@jyn514 jyn514 added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels May 26, 2023
@jyn514 jyn514 changed the title Steps that use crate_or_deps don't respect --exclude We are not running std tests for wasm May 26, 2023
@LuuuXXX
Copy link
Contributor

LuuuXXX commented Aug 22, 2023

This should be the main cause of the problem.

fn maybe_run(&self, builder: &Builder<'_>, pathsets: Vec<PathSet>) {
if pathsets.iter().any(|set| self.is_excluded(builder, set)) {
return;
}

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Sep 8, 2023
…an68

Fix Step Skipping Caused by Using the `--exclude` Option

The original code was overreacting to the `--exclude` option,
https://github.com/rust-lang/rust/blob/eadf69a6c6edfe220fc5b1b659e46e271d75a3a1/src/bootstrap/builder.rs#L257-L260
For example:
When `x test --exclude alloc` or `x test --exclude library/alloc` is passed, the entire libraray test is skipped.

Related issues:
rust-lang#112009
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Sep 8, 2023
Rollup merge of rust-lang#115088 - LuuuXXX:issue-112009, r=albertlarsan68

Fix Step Skipping Caused by Using the `--exclude` Option

The original code was overreacting to the `--exclude` option,
https://github.com/rust-lang/rust/blob/eadf69a6c6edfe220fc5b1b659e46e271d75a3a1/src/bootstrap/builder.rs#L257-L260
For example:
When `x test --exclude alloc` or `x test --exclude library/alloc` is passed, the entire libraray test is skipped.

Related issues:
rust-lang#112009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

2 participants