Stop using @str in the compiler

[emberian]

We almost never want it, and when we do, we're going to want to replace it with a custom interned string type rather than some GC type. We do a lot of pointless copies right now because we get ~str from almost everything and we constantly do str.to_managed().

For now, convert to &str where we can, but replace every use of str.to_managed() with ~str and mark with a comment like /* should be interned */.

[kaseyc]

Can I take this?

[emberian]

Go for it! Don't sweat too hard trying to remove all of them; the compiler can get real messy.

[kaseyc]

Quick question: For functions that are currently returning @str using str.to_managed, should they return&str or ~str?

[emberian]

They should return ~str. In general you can't return &str since it
needs to point at something.

On Sat, Nov 16, 2013 at 7:16 PM, Kasey Carrothers
[email protected]:

Quick question: For functions that are currently returning @str using
str.to_managed, should they return&str or ~str?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/10516#issuecomment-28639366
.

[dguenther]

Is this still in progress? I've been making a decent foray into this area, but I don't want to steal someone else's ticket.

[kaseyc]

Go for it. I've been struggling with it, and haven't had as much time as I hoped to work on it.

[pnkfelix]

@dguenther I think pcwalton was also working a bit on this (or something related to it) last week, so you may want to ping him (perhaps on IRC).

[emberian]

I have an in-progress patch somewhere, can't find the patch atm.

On Mon, Jan 13, 2014 at 11:45 AM, Felix S Klock II <[email protected]

wrote:

@dguenther https://github.com/dguenther I think pcwalton was also
working a bit on this (or something related to it) last week, so you may
want to ping him (perhaps on IRC).

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/10516#issuecomment-32186778
.

[dguenther]

Cool, I'll chat up pcwalton and see what progress he's made. I've got a working build with a significant portion of ~str usages removed (tests still need to be updated), but still more to go, and I'll definitely need some CR help to clean up and check my code. @cmr If you happen to run into that patch, let me know. It'd probably be a more solid base than what I've got so far.

edit: pcwalton is currently working on this, so I'm going to hunt down another ticket to work on.

[emberian]

Found it: https://github.com/cmr/rust/tree/issue-2243

On Mon, Jan 13, 2014 at 1:01 PM, Derek Guenther [email protected]:

Cool, I'll chat up pcwalton and see what progress he's made. I've got a
working build with a significant portion of ~str usages removed (tests
still need to be updated), but still more to go, and I'll definitely need
some CR help to clean up and check my code. @cmr https://github.com/cmrIf you happen to run into that patch, let me know. It'd probably be a more
solid base than what I've got so far.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/10516#issuecomment-32193904
.

[fhahn]

This issue seems kind of fixed, greping for "@str" in src/librustc does not give any results and in src/librustc @str is only used in a comment (I think this one line should be changed) and in two functions that are commented out.

I could create a tiny pull request, changing the comment if this would help to close this issue

[huonw]

@str is now completely removed from the language, not just the compiler. Closing.

(Feel free to submit that PR though.)