Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flock creates executable file #102531

Closed
daym opened this issue Oct 1, 2022 · 1 comment
Closed

flock creates executable file #102531

daym opened this issue Oct 1, 2022 · 1 comment
Labels
C-bug Category: This is a bug.

Comments

@daym
Copy link
Contributor

daym commented Oct 1, 2022

I tried this:

cargo build # anything

I expected to see this happen: The only regular files with executable bit inside target/ are the actual ELF executables.

Instead, this happened: The lock files for the incremental build also have the executable bit set (for example ./target/debug/incremental/ex1-zjfb4s71is3b/s-ge02ugy8lg-ga9xze.lock in a cargo newed example).

Meta

cargo 1.63.0-nightly (3f052d8ee 2022-05-12)

Same in current rust HEAD commit.

rustc --version --verbose:

rustc 1.63.0-nightly (c52b9c10b 2022-05-16)
binary: rustc
commit-hash: c52b9c10bfb5164015eb977ff498e0597ae63eb1
commit-date: 2022-05-16
host: x86_64-unknown-linux-musl
release: 1.63.0-nightly
LLVM version: 14.0.4

@daym daym added the C-bug Category: This is a bug. label Oct 1, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Oct 15, 2022
Remove "execute" bit from lock file permissions

Previously, flock would set the "execute" bit on Rust lock files. That makes no sense.

This patch clears the "execute" bit on Rust lock files.

See issue rust-lang#102531.
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 18, 2022
Remove "execute" bit from lock file permissions

Previously, flock would set the "execute" bit on Rust lock files. That makes no sense.

This patch clears the "execute" bit on Rust lock files.

See issue rust-lang#102531.
@aDotInTheVoid
Copy link
Member

aDotInTheVoid commented Oct 24, 2022

nixon@Ashtabula:/tmp/x$ cargo +nightly b
   Compiling x v0.1.0 (/tmp/x)
    Finished dev [unoptimized + debuginfo] target(s) in 0.62s
nixon@Ashtabula:/tmp/x$ ls -l target/debug/incremental/x-3s8v232olbyl4/s-gern9fvwl5-sqix3a.lock
-rw------- 1 nixon nixon 0 Oct 24 15:21 target/debug/incremental/x-3s8v232olbyl4/s-gern9fvwl5-sqix3a.lock

This seems to be fixed on latest nightly, so this issue can be closed

Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
Remove "execute" bit from lock file permissions

Previously, flock would set the "execute" bit on Rust lock files. That makes no sense.

This patch clears the "execute" bit on Rust lock files.

See issue rust-lang#102531.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

No branches or pull requests

3 participants