Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Stop using the Show impl for ast::Name in our symbols
When generating a unique symbol for things like closures or glue_drop, we call token::gensym() to create a crate-unique Name. Recently, Name changed its Show impl so it no longer prints as a number. This caused symbols like glue_drop:1542 to become glue_drop:"glue_drop"(1542), or in mangled form, glue_drop.$x22glue_drop$x22$LP$1542$RP$.
- Loading branch information
ff3d902
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from luqmana
at lilyball@ff3d902
ff3d902
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kballard/rust/fix_gensym_symbols = ff3d902 merged ok, testing candidate = 51ff6c0
ff3d902
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging kballard/rust/fix_gensym_symbols = ff3d902 into auto
ff3d902
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/633
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/633
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/632
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/633
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/630
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/631
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/630
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/636
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/631
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/630
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/633
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/631
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/631
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/632
ff3d902
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 51ff6c0