Skip to content

Commit

Permalink
Auto merge of #42500 - hsivonen:neon, r=japaric
Browse files Browse the repository at this point in the history
Change `llvm.neon.*` to `llvm.arm.neon.*` in the mapping for platform intrinsics

This avoids linker errors when using platform intrinsics on 32-bit ARM with
NEON.

Fixes hsivonen/simd#10.

I don't have an explanation why the old code might have worked when the `simd` crate was written, since the new LLVM intrinsic naming seems to have existed as early as 2012. Maybe LLVM accepted two naming schemes for a few years and dropped the `llvm.neon.*` version recently? I don't know.

Also, I don't know how to write a unit test for this.
  • Loading branch information
bors committed Jun 8, 2017
2 parents c799b37 + 0fb8414 commit ae3d387
Show file tree
Hide file tree
Showing 2 changed files with 391 additions and 391 deletions.
2 changes: 1 addition & 1 deletion src/etc/platform-intrinsics/arm.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"platform": "arm_v",
"intrinsic_prefix": "",
"llvm_prefix": "llvm.neon.v",
"llvm_prefix": "llvm.arm.neon.v",
"number_info": {
"signed": {
"kind": "s",
Expand Down
Loading

0 comments on commit ae3d387

Please sign in to comment.