Skip to content

Commit

Permalink
Remove redundant success expressions from steps
Browse files Browse the repository at this point in the history
  • Loading branch information
Kobzol committed Apr 29, 2024
1 parent 24bf359 commit adbc84c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ jobs:
run: echo "[CI_PR_NUMBER=$num]"
env:
num: ${{ github.event.number }}
if: success() && github.event_name == 'pull_request'
if: github.event_name == 'pull_request'

- name: add extra environment variables
run: src/ci/scripts/setup-environment.sh
Expand Down Expand Up @@ -219,7 +219,7 @@ jobs:
# adding the condition is helpful as this way CI will not silently skip
# deploying artifacts from a dist builder if the variables are misconfigured,
# erroring about invalid credentials instead.
if: success() && (github.event_name == 'push' || env.DEPLOY == '1' || env.DEPLOY_ALT == '1')
if: github.event_name == 'push' || env.DEPLOY == '1' || env.DEPLOY_ALT == '1'

# This job isused to tell bors the final status of the build, as there is no practical way to detect
# when a workflow is successful listening to webhooks only in our current bors implementation (homu).
Expand Down

0 comments on commit adbc84c

Please sign in to comment.