-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
As discovered in #9925, it turns out that we weren't using jemalloc on most platforms. Additionally, on some platforms we were using it incorrectly and mismatching the libc version of malloc with the jemalloc version of malloc. Additionally, it's not clear that using jemalloc is indeed a large performance win in particular situtations. This could be due to building jemalloc incorrectly, or possibly due to using jemalloc incorrectly, but it is unclear at this time. Until jemalloc can be confirmed to integrate correctly on all platforms and has verifiable large performance wins on platforms as well, it shouldn't be part of the default build process. It should still be available for use via the LD_PRELOAD trick on various architectures, but using it as the default allocator for everything would require guaranteeing that it works in all situtations, which it currently doesn't. Closes #9925
- Loading branch information
1 parent
a1848bc
commit 90911d7
Showing
102 changed files
with
2 additions
and
44,521 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
90911d7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at alexcrichton@90911d7
90911d7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/no-jemalloc = 90911d7 into auto
90911d7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/no-jemalloc = 90911d7 merged ok, testing candidate = df187a0
90911d7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2026
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2030
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1136
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1135
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2044
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1136
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1136
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2045
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1136
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1136
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/1215
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2029
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1134
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1136
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/1813
90911d7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = df187a0