TEMP: Silence false positives of unconditional recursive drop

rust-lang · Jul 20, 2023 · 58c4a2a · 58c4a2a
1 parent 5829b8c
commit 58c4a2a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/library/proc_macro/src/bridge/buffer.rs b/library/proc_macro/src/bridge/buffer.rs
@@ -120,6 +120,7 @@ impl Write for Buffer {
 
 impl Drop for Buffer {
     #[inline]
+    #[allow(unconditional_recursion)] // TODO: Fix false positive, maybe by analyzing MIR after drop elaboration?
     fn drop(&mut self) {
         let b = self.take();
         (b.drop)(b);

diff --git a/tests/ui/runtime/rt-explody-panic-payloads.rs b/tests/ui/runtime/rt-explody-panic-payloads.rs
@@ -9,6 +9,7 @@ use std::process::Command;
 struct Bomb;
 
 impl Drop for Bomb {
+    #[allow(unconditional_recursion)] // TODO: Fix false positive, this will panic, not recurse
     fn drop(&mut self) {
         std::panic::panic_any(Bomb);
     }