Skip to content

Commit

Permalink
add test checking that aggregate assignments reset memory to uninit f…
Browse files Browse the repository at this point in the history
…irst
  • Loading branch information
RalfJung committed Nov 28, 2023
1 parent cabfe8f commit 53eb910
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 0 deletions.
27 changes: 27 additions & 0 deletions src/tools/miri/tests/fail/uninit-after-aggregate-assign.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
#![feature(core_intrinsics)]
#![feature(custom_mir)]

use std::intrinsics::mir::*;
use std::ptr;

#[repr(C)]
struct S(u8, u16);

#[custom_mir(dialect = "runtime", phase = "optimized")]
fn main() {
mir! {
let s: S;
let sptr;
let sptr2;
let _val;
{
sptr = ptr::addr_of_mut!(s);
sptr2 = sptr as *mut [u8; 4];
*sptr2 = [0; 4];
*sptr = S(0, 0); // should reset the padding
_val = *sptr2; // should hence be UB
//~^ERROR: encountered uninitialized memory
Return()
}
}
}
15 changes: 15 additions & 0 deletions src/tools/miri/tests/fail/uninit-after-aggregate-assign.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
error: Undefined Behavior: constructing invalid value at [1]: encountered uninitialized memory, but expected an integer
--> $DIR/uninit-after-aggregate-assign.rs:LL:CC
|
LL | _val = *sptr2; // should hence be UB
| ^^^^^^^^^^^^^ constructing invalid value at [1]: encountered uninitialized memory, but expected an integer
|
= help: this indicates a bug in the program: it performed an invalid operation, and caused Undefined Behavior
= help: see https://doc.rust-lang.org/nightly/reference/behavior-considered-undefined.html for further information
= note: BACKTRACE:
= note: inside `main` at $DIR/uninit-after-aggregate-assign.rs:LL:CC

note: some details are omitted, run with `MIRIFLAGS=-Zmiri-backtrace=full` for a verbose backtrace

error: aborting due to 1 previous error

0 comments on commit 53eb910

Please sign in to comment.