-
Notifications
You must be signed in to change notification settings - Fork 13k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
LLVM internally uses `uint64_t` for array size, but the corresponding C API (`LLVMArrayType`) uses `unsigned int` so ths value is truncated. Therefore rustc generates wrong type for fixed-sized large vector e.g. `[0 x i8]` for `[0u8, ..(1 << 32)]`. This patch adds `LLVMRustArrayType` function for `uint64_t` support.
- Loading branch information
Showing
4 changed files
with
21 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a1786f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at klutzy@2a1786f
2a1786f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging klutzy/rust/llvmrust-arraytype = 2a1786f into auto
2a1786f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
klutzy/rust/llvmrust-arraytype = 2a1786f merged ok, testing candidate = 049f7625
2a1786f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/4938
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/5744
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/5743
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/4846
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/5842
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/4930
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/5844
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/4935
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2731
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/5837
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/4933
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/4948