Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add once_cell to crates available in playground #587

Closed
wants to merge 1 commit into from

Conversation

sunshowers
Copy link

The once_cell crate is super useful to play around with so it would be useful to have this in the playground :)

Please let me know if I did this right! I added once_cell by hand to both the Cargo.toml and to crate-information.json.

@dtolnay
Copy link
Member

dtolnay commented May 25, 2020

I believe those files are both generated (by the program in the top-crates directory).

@shepmaster
Copy link
Member

We don't currently accept one-off crate additions, but thanks! Please check out https://github.com/integer32llc/rust-playground/blob/master/CRATE_POLICY.md for more details.

@shepmaster shepmaster closed this May 26, 2020
@sunshowers
Copy link
Author

Thanks! Would you consider:
(a) increasing the number of crates, and/or
(b) making the transitive dependencies of the top crates available as well?

@sunshowers
Copy link
Author

(just checked and once_cell is in the top 300)

@dtolnay
Copy link
Member

dtolnay commented May 26, 2020

Transitive dependencies of the top crates are available. once_cell gets pulled in now by tokio (top 100) -> signal-hook-registry -> arc-swap -> once_cell.
https://github.com/integer32llc/rust-playground/blob/ab9c098daaeec1fb615f4cf4ec8c355371e20c5b/compiler/base/Cargo.toml#L558-L560

@shepmaster
Copy link
Member

Would you consider

Please read the aforementioned policy, which discusses whether transitive dependencies are included (they are) as well as how to discuss changes to the policy. I've written it so that I can stop repeating myself.

@sunshowers
Copy link
Author

Apologies, I missed that because it wasn't on the bulleted list. I've submitted #603 with a small rewording -- feel free to accept/decline if it makes sense to you. Thanks.

@sunshowers sunshowers deleted the once_cell branch May 26, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants