[fn_params_excessive_bools] Make it possible to allow the lint at the method level
#9698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #9733) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Sorry, I missed this over the week, it has been pretty chaotic. I should have a bit more time over the coming weeks. This is on my priority list for this weekend, so you'll have a review by Sunday. You can still rebase :)
You are welcome to commit that as well, more tests rarely hurt :) |
xFrednet
reviewed
Oct 29, 2022
xFrednet
reviewed
Nov 1, 2022
changelog: [`fn_params_excessive_bools`] Make it possible to allow the lint at the method level
Should not lint because the trait might not be changeable by the user We only lint in the trait definition
xFrednet
approved these changes
Nov 13, 2022
|
Looks good to me, thank you for the fix! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: FP: [
fn_params_excessive_bools]:#[allow]now works on methodsfix #9687
Tested without committing but
#[allow]ing now works. Also rewrote the lint to be a late lint while at it :)r? @xFrednet