Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix almost_complete_letter_range false positive. #9467

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Fix almost_complete_letter_range false positive. #9467

merged 3 commits into from
Sep 13, 2022

Conversation

pyhrr0
Copy link
Contributor

@pyhrr0 pyhrr0 commented Sep 11, 2022 •
edited by giraffate
Loading

changelog: Fix [almost_complete_letter_range] false positive in an external macro

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 11, 2022
@pyhrr0 pyhrr0 changed the title Stop lint from checking code expanded from macros. Fix almost_complete_letter_range false positive. Sep 11, 2022
@Alexendoo
Copy link
Member

context: #9179 (comment)

giraffate
giraffate reviewed Sep 12, 2022
View reviewed changes
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the tests be added? These docs would be helpful, and feel free to ask us.

@giraffate giraffate added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Sep 12, 2022
@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Sep 13, 2022

📌 Commit 69c7d2c has been approved by giraffate

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 13, 2022

⌛ Testing commit 69c7d2c with merge 826a893...

@bors
Copy link
Contributor

bors commented Sep 13, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 826a893 to master...

@bors bors merged commit 826a893 into rust-lang:master Sep 13, 2022
@giraffate giraffate mentioned this pull request Sep 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giraffate giraffate giraffate left review comments

Assignees

@giraffate giraffate

Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pyhrr0 @rust-highfive @Alexendoo @giraffate @bors