Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false-positive in equatable_if_let #9074

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

daxpedda
Copy link
Contributor

Was linting in external macros. I guess now that I know about #8694 it seems all kinda pointless until we resolve that.

Nevertheless, it's an improvement.

Fixes #9066.

changelog:equatable_if_let No longer lint on macros

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 30, 2022
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 30, 2022

📌 Commit b705107 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Jun 30, 2022

⌛ Testing commit b705107 with merge d7e5dab...

@bors
Copy link
Contributor

bors commented Jun 30, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing d7e5dab to master...

@bors bors merged commit d7e5dab into rust-lang:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False Positive equatable_if_let in macro
4 participants