Fix #[expect] for most clippy lints
#9046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
xFrednet
force-pushed
the
rust-97660-expection-something-something
branch
from
6c50845 to
4d41a97
Compare
6 tasks
flip1995
reviewed
Jun 27, 2022
Jarcho
reviewed
Jun 28, 2022
tests/ui/boxed_local.rs
Outdated
| @@ -202,3 +203,8 @@ mod issue4804 { | |||
| fn foo(x: Box<u32>) {} | |||
| } | |||
| } | |||
|
|
|||
| #[expect(clippy::boxed_local)] | |||
There was a problem hiding this comment.
Shouldn't this be on the argument?
There was a problem hiding this comment.
I wasn't sure, sometimes I forget that attributes also work on arguments ^^. I've updated the test.
|
Thank you. @bors r+ |
|
📌 Commit d11618e has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes most
#[expect]- lint interactions listed in rust-lang/rust#97660. My comment in the issue shows the current progress (Once this is merged). I plan to work onduplicate_modandmultiple_inherent_impland leave the rest for later. I feel like stabilizing the feature is more important than fixing the last few nits, which currently also don't work with#[allow].changelog: none
r? @Jarcho
cc: rust-lang/rust#97660