Address unnecessary_to_owned
false positive
#8794
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposed fix for #8759 is to revise the conditions that delineate
redundant_clone
andunnecessary_to_owned
:This change causes a few cases that were previously flagged by
unnecessary_to_owned
to no longer be flagged. But one could argue those cases would be better handled byredundant_clone
.Closes #8759
changelog: none