Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #8239: Printed hint for lint or_fun_call is cropped and does no… #8292

Merged
merged 3 commits into from
Jan 17, 2022
Merged

issue #8239: Printed hint for lint or_fun_call is cropped and does no… #8292

merged 3 commits into from
Jan 17, 2022

Conversation

marekdownar
Copy link
Contributor

@marekdownar marekdownar commented Jan 15, 2022 •
edited by xFrednet
Loading

fixes #8239

changelog: [or_fun_call]: if suggestion contains more lines than MAX_SUGGESTION_HIGHLIGHT_LINES it is stripped to one line

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 15, 2022
@llogiq
Copy link
Contributor

llogiq commented Jan 15, 2022

As @xFrednet wrote, I would expect at least a test to ensure correct behavior.

@marekdownar
Copy link
Contributor Author

@xFrednet
I will try to provide fix it in about 2 hours with suitable test case.

@xFrednet
Copy link
Member

Thank you, feel free to reach out if you need help 🙃

xFrednet
xFrednet approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version looks good to me, one optional NIT and one question.

BTW, all your commits are marked as Unverified. This is not a problem, but I wanted to mention it in case this was unintended 🙃

tests/ui/or_fun_call.fixed Outdated Show resolved Hide resolved
clippy_lints/src/methods/or_fun_call.rs Outdated Show resolved Hide resolved
@xFrednet
Copy link
Member

Looks good to me, thank you for the changes! 👍

FYI @marekdownar: I've updated the lint description, as the changelog entry has to be on the same line for the pipeline to pass.

I hope @llogiq will be fine with me stealing this r+

@bors r+

@bors
Copy link
Contributor

bors commented Jan 17, 2022

📌 Commit 69d78ce has been approved by xFrednet

@bors
Copy link
Contributor

bors commented Jan 17, 2022

⌛ Testing commit 69d78ce with merge 8d14c94...

@bors
Copy link
Contributor

bors commented Jan 17, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 8d14c94 to master...

@bors bors merged commit 8d14c94 into rust-lang:master Jan 17, 2022
@marekdownar marekdownar deleted the 8239 branch January 17, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xFrednet xFrednet xFrednet approved these changes

Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Printed hint for lint or_fun_call is cropped and does not show the solution
5 participants
@marekdownar @rust-highfive @llogiq @xFrednet @bors