used_underscore_binding: do not lint on await desugaring
#5535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ thanks! |
|
📌 Commit fc5fc63 has been approved by |
phansch
approved these changes
Apr 28, 2020
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
Did this not land in 1.44? I'm getting the lint on |
anupdhml
added a commit
to tremor-rs/tremor-runtime
that referenced
this pull request
Jun 5, 2020
Until the clippy bug generating a ton of warnings makes it to stable: rust-lang/rust-clippy#5535 Also pin clippy checks in CI for the same rust version as the one specified in the project rust-toolchain file --- Fix test issues seen with 1.44 pre-emptively. We should also pin rust versions on those CI runs now (will be done as part of a separate cleanup).
anupdhml
added a commit
to tremor-rs/tremor-runtime
that referenced
this pull request
Jun 5, 2020
Until the clippy bug generating a ton of warnings makes it to stable: rust-lang/rust-clippy#5535 Also pin clippy checks in CI for the same rust version as the one specified in the project rust-toolchain file --- Fix test issues seen with 1.44 pre-emptively. We should also pin rust versions on those CI runs now (will be done as part of a separate cleanup).
Licenser
pushed a commit
to tremor-rs/tremor-runtime
that referenced
this pull request
Jun 5, 2020
Until the clippy bug generating a ton of warnings makes it to stable: rust-lang/rust-clippy#5535 Also pin clippy checks in CI for the same rust version as the one specified in the project rust-toolchain file --- Fix test issues seen with 1.44 pre-emptively. We should also pin rust versions on those CI runs now (will be done as part of a separate cleanup).
Erk-
referenced
this pull request
in twilight-rs/twilight
Jun 5, 2020
When the user uses a retrieval request, like getting a user by ID, the
future output is a `Result<Option<T>>`. The code to handle 404 response
status codes didn't actually exist, so it'd always either be
`Ok(Some(T))` or `Err(E)`.
This patch adds support for handling 404 responses and returning
`Ok(None)` where encountered on select retrieval routes.
Here's an example of output:
```
Getting guild member for user 1
Ok(None)
Getting guild member for user 640434332485287936
Ok(Some(Member { deaf: false, guild_id: None, hoisted_role: Non.....
```
Closes #157.
Approved-by: AEnterprise <[email protected]>
Approved-by: Valdemar Erk <[email protected]>
Merged-by: Valdemar Erk <[email protected]>
Signed-off-by: Vivian Hellyer <[email protected]>
Licenser
pushed a commit
to tremor-rs/tremor-runtime
that referenced
this pull request
Jun 22, 2020
Until the clippy bug generating a ton of warnings makes it to stable: rust-lang/rust-clippy#5535 Also pin clippy checks in CI for the same rust version as the one specified in the project rust-toolchain file --- Fix test issues seen with 1.44 pre-emptively. We should also pin rust versions on those CI runs now (will be done as part of a separate cleanup).
Licenser
pushed a commit
to tremor-rs/tremor-runtime
that referenced
this pull request
Jun 23, 2020
Until the clippy bug generating a ton of warnings makes it to stable: rust-lang/rust-clippy#5535 Also pin clippy checks in CI for the same rust version as the one specified in the project rust-toolchain file --- Fix test issues seen with 1.44 pre-emptively. We should also pin rust versions on those CI runs now (will be done as part of a separate cleanup).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: used_underscore_binding: do not lint on
awaitdesugaringFixes #5360