Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecimalLiteralRepresentation simplification #4758

Merged
merged 1 commit into from Nov 7, 2019
Merged

DecimalLiteralRepresentation simplification #4758

merged 1 commit into from Nov 7, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 31, 2019

Remove recalculation of literal value.

changelog: none

Remove recalculation of literal value.
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 31, 2019

📌 Commit 4e78547 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Oct 31, 2019

⌛ Testing commit 4e78547 with merge ce5d22e...

bors added a commit that referenced this pull request Oct 31, 2019
`DecimalLiteralRepresentation` simplification

Remove recalculation of literal value.

changelog: none
@bors
Copy link
Contributor

bors commented Oct 31, 2019

💔 Test failed - checks-travis

@ghost
Copy link
Author

ghost commented Nov 1, 2019

The stdarch (stdsimd) build is failing. Should we remove it from our integration tests or wait for them to fix it?

@flip1995
Copy link
Member

flip1995 commented Nov 1, 2019

Yes, it's not a Clippy bug.

flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Nov 7, 2019
`DecimalLiteralRepresentation` simplification

Remove recalculation of literal value.

changelog: none
flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Nov 7, 2019
`DecimalLiteralRepresentation` simplification

Remove recalculation of literal value.

changelog: none
bors added a commit that referenced this pull request Nov 7, 2019
Rollup of 4 pull requests

Successful merges:

 - #4697 (restriction lint for `std::process::exit`)
 - #4757 (Fix Deprecated lints don't expand)
 - #4758 (`DecimalLiteralRepresentation` simplification)
 - #4769 (don't warn on CRLF in `with_newline` lints)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Nov 7, 2019
Rollup of 4 pull requests

Successful merges:

 - #4697 (restriction lint for `std::process::exit`)
 - #4757 (Fix Deprecated lints don't expand)
 - #4758 (`DecimalLiteralRepresentation` simplification)
 - #4769 (don't warn on CRLF in `with_newline` lints)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Nov 7, 2019

⌛ Testing commit 4e78547 with merge 426c05a...

bors added a commit that referenced this pull request Nov 7, 2019
`DecimalLiteralRepresentation` simplification

Remove recalculation of literal value.

changelog: none
@bors
Copy link
Contributor

bors commented Nov 7, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 426c05a to master...

@bors bors merged commit 4e78547 into rust-lang:master Nov 7, 2019
@ghost ghost deleted the dec_lit_20191031 branch December 26, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants